lkml.org 
[lkml]   [2008]   [Jan]   [28]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateMon, 28 Jan 2008 09:49:12 -0200
FromMauro Carvalho Chehab <>
SubjectRe: [v4l-dvb-maintainer] 2.6.25 regression: VIDEO_DEV=y/m, I2C=n compile error
> Maybe the kernel headers should provide a couple macros for testing
> configs, since people get it wrong over and over again?
> 
> #define CONFIG_ON(x) (defined(CONFIG_##x) || defined(CONFIG_##x##_MODULE))
> #define CONFIG_AVAIABLE(x) (defined(CONFIG_##x) || (defined(MODULE) && defined(CONFIG_##x##_MODULE)))

Seems a good idea to me.
> 
> Not sure what to do about VIDEO_DEV=y, I2C=m.  It should be possible except
> for this function.

I don't see much sense on allowing v4l2-common being in-kernel, while having
I2C as module. Also, creating a separate module for just a single function
seems to be overkill.

IMO, in this specific case, v4l2-common should also be a module. Not sure,
however,the better syntax on Kconfig. Once, someone suggested a very weird
syntax, like:

	depends on I2C if I2C


Cheers,
Mauro


\
 
 \ /
  Last update: 2008-01-28 12:53    [from the cache]
©2003-2008