lkml.org 
[lkml]   [2008]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: (Updated) [Patch] Shut up warnings from files under drivers/
    On 01/27/2008 05:15 AM, WANG Cong wrote:
    > Fix defined-but-not-used warnings from files under drivers/,
    > such as:
    >
    > drivers/char/applicom.c:68: warning: ‘applicom_pci_tbl’ defined but not used
    >
    > Compile tests passed.
    >
    > Cc: Jeff Garzik <jeff@garzik.org>
    > Cc: Greg KH <gregkh@suse.de>
    > Cc: Sam Ravnborg <sam@ravnborg.org>
    > Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
    >
    > ---
    >
    > diff --git a/drivers/char/applicom.c b/drivers/char/applicom.c
    > index 1f0b752..97171ad 100644
    > --- a/drivers/char/applicom.c
    > +++ b/drivers/char/applicom.c
    > @@ -65,7 +65,7 @@ static char *applicom_pci_devnames[] = {
    > "PCI2000PFB"
    > };
    >
    > -static struct pci_device_id applicom_pci_tbl[] = {
    > +static struct pci_device_id applicom_pci_tbl[] __used = {
    > { PCI_VENDOR_ID_APPLICOM, PCI_DEVICE_ID_APPLICOM_PCIGENERIC,
    > PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
    > { PCI_VENDOR_ID_APPLICOM, PCI_DEVICE_ID_APPLICOM_PCI2000IBS_CAN,

    I have probably a better fix with pci_match_id() referencing this array.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2008-01-27 10:11    [W:0.044 / U:1.472 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site