lkml.org 
[lkml]   [2008]   [Jan]   [27]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateSat, 26 Jan 2008 22:00:29 -0800
FromAndrew Morton <>
SubjectRe: [PATCH 07/19] dlm: swap bytes for rcom lock reply
> On Thu, 24 Jan 2008 10:50:30 -0600 David Teigland <teigland@redhat.com> wrote:
>  void dlm_rcom_in(struct dlm_rcom *rc)
>  {
>  	struct dlm_header *hd = (struct dlm_header *) rc;

aww, c'mon guys, this is nonsense.

	struct dlm_header *hd = &rc->rc_header;

there seems to be rather a lot of this unnecessary casting going on in dlm. 
Please do a hunt-and-exterminate.



\
 
 \ /
  Last update: 2008-01-27 07:03    [from the cache]
©2003-2008