Messages in this thread | | | Date | Sun, 27 Jan 2008 08:47:36 -0800 | From | Randy Dunlap <> | Subject | Re: [PATCH] Add iSCSI iBFT support (v0.4.5) |
| |
Andrew Morton wrote:
>> int __initdata user_defined_memmap = 0;
> checkpatch should have told you that this "= 0" shouldn't be there. But it > doesn't.
checkpatch checks for static initializers, not non-static ones. Should that be changed?
>> + for (pos = (u8 *)hdr; pos < (u8 *)hdr + len; pos ++) >> > > checkpatch should have caught the " ++" but didn't. I think it used to. > It seems to be going backwards?
-- ~Randy
| |