lkml.org 
[lkml]   [2008]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Add iSCSI iBFT support (v0.4.5)
Andrew Morton wrote:

>> int __initdata user_defined_memmap = 0;

> checkpatch should have told you that this "= 0" shouldn't be there. But it
> doesn't.


checkpatch checks for static initializers, not non-static ones.
Should that be changed?



>> + for (pos = (u8 *)hdr; pos < (u8 *)hdr + len; pos ++)
>>
>
> checkpatch should have caught the " ++" but didn't. I think it used to.
> It seems to be going backwards?


--
~Randy


\
 
 \ /
  Last update: 2008-01-27 18:01    [W:0.433 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site