lkml.org 
[lkml]   [2008]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Patch] Shut up warnings from files under drivers/
    WANG Cong wrote:
    > diff --git a/drivers/video/kyro/fbdev.c b/drivers/video/kyro/fbdev.c
    > index acb9370..437ebd0 100644
    > --- a/drivers/video/kyro/fbdev.c
    > +++ b/drivers/video/kyro/fbdev.c
    > @@ -90,7 +90,9 @@ static int nomtrr __devinitdata = 0;
    >
    > /* PCI driver prototypes */
    > static int kyrofb_probe(struct pci_dev *pdev, const struct pci_device_id *ent);
    > +#if defined(MODULE) || defined(CONFIG_HOTPLUG)
    > static void kyrofb_remove(struct pci_dev *pdev);
    > +#endif
    >
    > static struct fb_videomode kyro_modedb[] __devinitdata = {
    > {
    > @@ -754,6 +756,7 @@ out_unmap:
    > return -EINVAL;
    > }
    >
    > +#if defined(MODULE) || defined(CONFIG_HOTPLUG)
    > static void __devexit kyrofb_remove(struct pci_dev *pdev)
    > {
    > struct fb_info *info = pci_get_drvdata(pdev);
    > @@ -783,6 +786,7 @@ static void __devexit kyrofb_remove(struct pci_dev *pdev)
    > pci_set_drvdata(pdev, NULL);
    > framebuffer_release(info);
    > }
    > +#endif


    Quite strange -- due to __devexit_p() and the __devexit marker, ifdefs
    should not be needed.

    I would look into why that isn't working as designed in these cases...

    Jeff




    \
     
     \ /
      Last update: 2008-01-26 10:59    [W:3.576 / U:0.208 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site