lkml.org 
[lkml]   [2008]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [kvm-devel] [PATCH 3/8] SVM: add module parameter to disable Nested Paging
    Joerg Roedel wrote:
    >>> +static char *npt = "on";
    >>> +
    >>> +module_param(npt, charp, S_IRUGO);
    >>>
    >>>
    >> This would probably be better as an integer. Then we don't have to do nasty things like
    >> implicitly cast a literal to a char *.
    >>
    >
    > Hmm, I used int for that first but typing npt=off seemed more
    > userfriendly to me than npt=0. So I used char* for it.
    >

    I expect this to be rarely used by users, so the simpler int is
    preferable (and also consistent with vmx's bypass_guest_pf and enable_vpid).

    --
    Any sufficiently difficult bug is indistinguishable from a feature.



    \
     
     \ /
      Last update: 2008-01-26 19:41    [W:0.022 / U:1.368 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site