Messages in this thread |  | | | From | Junio C Hamano <> | | Subject | Re: [PATCH] Convert ext4_ioctl to an unlocked_ioctl | | Date | Thu, 24 Jan 2008 22:35:16 -0800 |
Mathieu Segaud <mathieu.segaud@regala.cx> writes:
> Signed-off-by: Mathieu Segaud <mathieu.segaud@regala.cx>
> ---
> fs/ext4/dir.c | 2 +-
> fs/ext4/file.c | 2 +-
> fs/ext4/ioctl.c | 161 ++++++++++++++++++++++++++++++++---------------
> include/linux/ext4_fs.h | 3 +-
> 4 files changed, 112 insertions(+), 56 deletions(-)
>
> diff --git a/fs/ext4/dir.c b/fs/ext4/dir.c
> index f612bef..8f6677a 100644
> --- a/fs/ext4/dir.c
> +++ b/fs/ext4/dir.c
> @@ -42,7 +42,7 @@ const struct file_operations ext4_dir_operations = {
> .llseek = generic_file_llseek,
> .read = generic_read_dir,
> .readdir = ext4_readdir, /* we take BKL. needed?*/
> - .ioctl = ext4_ioctl, /* BKL held */
> + .unlocked_ioctl = ext4_ioctl, /* BKL held */
Wasn't the purpose of this whole exercise to eventually allow
them to be outside BKL? IOW, don't you want to drop this
comment for the .unlocked_ioctl member of this struct?
|  |