lkml.org 
[lkml]   [2008]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -mm] define empty unxlate_dev_mem_ptr on AVR32
On Wed, 23 Jan 2008 22:53:54 +1100
Ben Nizette <bn@niasdigital.com> wrote:

> /*
> + * We just keep an empty definition of this around (a-la the asm-generic
> + * implementation) to keep /dev/mem happy
> + */
> +#define unxlate_dev_mem_ptr(p, a) {}

Thanks, but this should be either

#define unxlate_dev_mem_ptr(p, a) do { } while (0)

or

static inline void unxlate_dev_mem_ptr(unsigned long phys, void *addr)
{
}

I prefer the latter.

Btw, the breakage was introduced by git-x86.patch. Should I take the
fix through my avr32 tree?

Haavard


\
 
 \ /
  Last update: 2008-01-24 11:33    [W:0.084 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site