Messages in this thread | | | Date | Thu, 24 Jan 2008 11:29:11 +0100 | From | Haavard Skinnemoen <> | Subject | Re: [PATCH -mm] define empty unxlate_dev_mem_ptr on AVR32 |
| |
On Wed, 23 Jan 2008 22:53:54 +1100 Ben Nizette <bn@niasdigital.com> wrote:
> /* > + * We just keep an empty definition of this around (a-la the asm-generic > + * implementation) to keep /dev/mem happy > + */ > +#define unxlate_dev_mem_ptr(p, a) {}
Thanks, but this should be either
#define unxlate_dev_mem_ptr(p, a) do { } while (0)
or
static inline void unxlate_dev_mem_ptr(unsigned long phys, void *addr) { }
I prefer the latter.
Btw, the breakage was introduced by git-x86.patch. Should I take the fix through my avr32 tree?
Haavard
| |