lkml.org 
[lkml]   [2008]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/6] io context sharing: preliminary support
    On Wed, Jan 23 2008, Andrew Morton wrote:
    > > On Tue, 22 Jan 2008 10:49:17 +0100 Jens Axboe <jens.axboe@oracle.com> wrote:
    > > -void put_io_context(struct io_context *ioc)
    > > +int put_io_context(struct io_context *ioc)
    > > {
    > > if (ioc == NULL)
    > > - return;
    > > + return 1;
    > >
    > > BUG_ON(atomic_read(&ioc->refcount) == 0);
    > >
    > > @@ -3856,7 +3856,9 @@ void put_io_context(struct io_context *ioc)
    > > rcu_read_unlock();
    > >
    > > kmem_cache_free(iocontext_cachep, ioc);
    > > + return 1;
    > > }
    > > + return 0;
    > > }
    >
    > Document the return value? (and the function)

    Will do.

    > I assume this return value gets used in some other patch.

    Yeah, it is.

    --
    Jens Axboe



    \
     
     \ /
      Last update: 2008-01-24 08:39    [W:0.024 / U:33.236 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site