Messages in this thread Patch in this message | | | Subject | Re: [PATCH 23/27] NFS: Fix memory leak [try #2] | From | Trond Myklebust <> | Date | Thu, 24 Jan 2008 16:15:29 -0500 |
| |
On Wed, 2008-01-23 at 17:22 +0000, David Howells wrote: > Fix a memory leak whereby multiple clientaddr=xxx mount options just overwrite > the duplicated client_address option pointer, without freeing the old memory. > > Signed-off-by: David Howells <dhowells@redhat.com> > --- > > fs/nfs/super.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > > diff --git a/fs/nfs/super.c b/fs/nfs/super.c > index 0b0c72a..7f5e747 100644 > --- a/fs/nfs/super.c > +++ b/fs/nfs/super.c > @@ -936,6 +936,7 @@ static int nfs_parse_mount_options(char *raw, > string = match_strdup(args); > if (string == NULL) > goto out_nomem; > + kfree(mnt->client_address); > mnt->client_address = string; > break; > case Opt_mountaddr:
Thanks. This fix has already been applied to the NFS git tree.
| |