Messages in this thread | | | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: [PATCH] ppc: fix #ifdef-s in mediabay driver | Date | Wed, 23 Jan 2008 13:47:38 +0100 |
| |
On Wednesday 23 January 2008, Benjamin Herrenschmidt wrote: > > On Wed, 2008-01-23 at 01:58 +0100, Bartlomiej Zolnierkiewicz wrote: > > I'm more worried about breaking automatic build checking (make randconfig) > > than a few extra bytes so if you remove all #ifdefs you'll have to either > > make BLK_DEV_IDE_PMAC select PMAC_MEDIABAY or make PMAC_MEDIABAY depend > > on BLK_DEV_IDE_PMAC (otherwise BLK_DEV_IDE=n && PMAC_MEDIABAY=y will fail > > since mediabay.c is referencing IDE code). > > I was thinking about having the pmac arch code provide an exported > function pointer to put the hook in to avoid that problem.
BTW the other pending IDE patches (yet to posted) include rework of IDE hot-plug support for PMAC media-bay so ide_init_hwif_ports()/ide_register_hw() /ide_unregister() calls in mediabay.c will be replaced by "something else".
| |