Messages in this thread | | | Date | Wed, 23 Jan 2008 10:57:57 +0000 | From | Mel Gorman <> | Subject | Re: [PATCH 0/2] Relax restrictions on setting CONFIG_NUMA on x86 |
| |
On (23/01/08 11:45), Andi Kleen didst pronounce: > > > > i386 already has srat parsing code (just written in a horrible hackish > > > way); but it exists arch/x86/kernel/srat_32.c > > > > Yes, I spotted that. Enabling it required a Kconfig change > > does it?
hmm, just a removal of (X86_SUMMIT || X86_GENERICARCH). When I was testing this I was probably using a PC-compatible configuration as that is what I was enabling at the time. It's a similar restriction for BOOT_IOREMAP.
> I was pretty sure that a !NUMAQ i386 CONFIG_NUMA build > already used that.
Presumably a GENERICARCH configuration
> At least that was the case when I last looked. If that > has changed it must have bitrotted recently. >
I don't think it has bit-rotted. I was just not using a GENERICARCH configuration.
> > or two and > > enabling BOOT_IOREMAP. It then crashes early in boot on a call to strlen() > > so I went with the stubs and SRAT disabled for the moment. > > Crashed on a Opteron box? That was always the case >
Yeah, elm3b6 from test.kernel.org is an Opteron-based NUMA machine. Oddly it's good to know that the nature of the crash has not changed.
> If it crashed on a (older) Summit then it likely bitrotted, because that > worked at some point. The code was originally written by Pat G. for Summit1 > and I believe was at least used by some people (no distributions) for S2, > possible 3 too. >
Unfortunately, I don't have access to a Summit box so I cannot verify.
> > Ok, understood. When I next revisit this, I'll look at making ACPI_SRAT > > and BOOT_IOREMAP work on normal machines and see what happens. Thanks. > > Again the problem shouldn't be normal machines, but non Summit NUMA systems. >
Grand. I'll get back to this soon and see what can be done.
-- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab
| |