lkml.org 
[lkml]   [2008]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateWed, 23 Jan 2008 06:47:47 +0100
FromChristoph Hellwig <>
SubjectRe: 2.6.24-rc8-mm1: sparc64 warning at fs/file_table.c:49 __fput+0x1a8/0x1e0()
On Tue, Jan 22, 2008 at 03:13:58PM -0800, Dave Hansen wrote:
> The emergency remount code forcibly removes FMODE_WRITE from
> filps. The r/o bind mount code notices that this was done
> without a proper mnt_drop_write() and properly gives a
> warning.
>
> This patch does a mnt_drop_write() and also notes in the
> filp that this was done to suppress any warning that would
> have otherwise been triggered.
>
> I also wonder if inode->i_writecount is made inconsistent
> by the emergency remount code. I guess it is, but the
> damage is limited to a single inode instead of being
> visible more globally like the mnt write count. Probably
> not really worth fixing.

The right fix is to not simply remove FMODE_WRITE, but just remove
this whole function. Until we have a proper revoke it will cause more
harm than good.


\
 
 \ /
  Last update: 2008-01-23 06:55    [from the cache]
©2003-2010