[lkml]   [2008]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: fixed a bug of adma in rhel4u5 with HDS7250SASUN500G.
    Kuan Luo wrote:
    > First thank davide to help to send the attachment.
    > Robert,
    > The patch is to solve the error message "ata1: CPB flags CMD err,
    > flags=0x11" when testing HDS7250SASUN500G in rhel4u5.
    > I tested this hd in 2.6.24-rc7 which needed to remove the mask in
    > blacklist to run the ncq and the same error also showed up.
    > I traced the bug and found that the interrupt finished a command (for
    > example, tag=0) when the driver got that adma status is
    > NV_ADMA_STAT_DONE and cpb->resp_flags is NV_CPB_RESP_DONE.
    > However, For this hd, the drive maybe didn't clear bit 0 at this moment.
    > It meaned the hardware had not completely finished the command.
    > If at the same time the driver freed the command(tag 0) and sended
    > another command (tag 0), the error happened.
    > The notifier register is 32-bit register containing notifier value.
    > Value is bit vector containing one bit per tag number (0-31) in
    > corresponding bit positions (bit 0 is for tag 0, etc). When bit is set
    > then ADMA indicates that command with corresponding tag number completed
    > execution.
    > So i added the check notifier code. Sometimes i saw that the notifier
    > reg set some bits , but the adma status set NV_ADMA_STAT_CMD_COMPLETE
    > ,not NV_ADMA_STAT_DONE. So i added the NV_ADMA_STAT_CMD_COMPLETE check
    > code.

    Kuan, does this patch (using the notifiers to see if the command is
    really done) still work if one port on the controller has ADMA disabled
    because it's in ATAPI mode? I seem to recall Allen Martin mentioning
    that notifiers wouldn't work in this case.

     \ /
      Last update: 2008-01-24 01:47    [W:0.022 / U:0.120 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site