lkml.org 
[lkml]   [2008]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: x86: GEODE fix MFGPT input clock value
    Hi,

    Jordan Crouse schrieb:
    > On 23/01/08 23:11 +0100, Willy Tarreau wrote:
    >> Hi Peter,
    >>
    >> On Wed, Jan 23, 2008 at 01:59:32PM -0800, H. Peter Anvin wrote:
    >>> Willy Tarreau wrote:
    >>>> The GEODE MFGPT code assumed that 32kHz was 32000 Hz while the boards
    >>>> run on a 32.768 kHz digital watch crystal. In practise, it will not
    >>>> change the timer's frequency as the skew was only 2.4%, but it
    >>>> should provide more accurate intervals.
    >>>> - * Divisor Hz Min Delta (S) Max Delta (S)
    >>> Seconds are "s", not "S" (S = siemens.)
    >> You're quite right. Same as we should write kHz and not Khz. But I'm
    >> used to change other people's work and particularly comments the least
    >> possible. Do you want an update ?
    >
    > Please do - I don't mind if you change the comments - better that they
    > are right.

    While you are on it, please include this one:

    --- a/arch/x86/kernel/mfgpt_32.c 2008-01-24 00:08:20.000000000 +0100
    +++ b/arch/x86/kernel/mfgpt_32.c 2008-01-24 00:05:17.000000000 +0100
    @@ -361,7 +361,7 @@
    &mfgpt_clockevent);

    printk(KERN_INFO
    - "mfgpt-timer: registering the MFGT timer as a clock event.\n");
    + "mfgpt-timer: registering the MFGPT timer as a clock event.\n");
    clockevents_register_device(&mfgpt_clockevent);

    return 0;

    > Jordan
    >

    Arnd


    \
     
     \ /
      Last update: 2008-01-24 00:19    [W:0.045 / U:59.760 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site