| Date | Wed, 23 Jan 2008 14:07:16 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH 36/49] ext4: Add EXT4_IOC_MIGRATE ioctl |
| |
> On Mon, 21 Jan 2008 22:02:15 -0500 "Theodore Ts'o" <tytso@MIT.EDU> wrote: > The below patch add ioctl for migrating ext3 indirect block mapped inode > to ext4 extent mapped inode.
This patch adds lots of weird and inexplicable single- and double-newlines in inappropriate places. However it frequently forgets to add newlines between end-of-locals and start-of-code, which is usual practice.
+struct list_blocks_struct { + ext4_lblk_t first_block, last_block; + ext4_fsblk_t first_pblock, last_pblock; +}; This structure would benefit from some code comments.
|