lkml.org 
[lkml]   [2008]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch] x86: test case for the RODATA config option
From
Date
Arjan van de Ven <arjan@infradead.org> writes:

> This patch adds a test module for the DEBUG_RODATA config
> option to make sure change_page_attr() did indeed make
> "const" data read only.

The only that this does that is not done pretty much equivalently
by pageattr-test.c (it just checks G instead of W) is testing the kernel
text mapping on 64bit. On 32bit it is fully redundant I believe.

Testing the kernel mapping might be a good idea, but I would
suggest adding it to pageattr-test.c

Yes I'm sure these basic facts will not stop it from being
applied anyways; just wanted to point it out for the benefit
of the list readers.

-Andi


\
 
 \ /
  Last update: 2008-01-23 10:13    [W:0.067 / U:1.544 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site