lkml.org 
[lkml]   [2008]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 08/20 -v5] initialize the clock source to jiffies clock.
Steven Rostedt wrote:
> The latency tracer can call clocksource_read very early in bootup and
> before the clock source variable has been initialized. This results in a
> crash at boot up (even before earlyprintk is initialized). Since the
> clock->read variable points to NULL.
>
> This patch simply initializes the clock to use clocksource_jiffies, so
> that any early user of clocksource_read will not crash.

There's a similar problem with reads of sched_clock() too early
on some architectures. This problem reminds me of a fix I need
to re-send to the ARM mailing list. That aside, I heartily recommend
applying this patch, whether the rest of this system gets mainlined
or not.

FWIW:
Acked-by: Tim Bird <tim.bird@am.sony.com>

-- Tim


=============================
Tim Bird
Architecture Group Chair, CE Linux Forum
Senior Staff Engineer, Sony Corporation of America
=============================


\
 
 \ /
  Last update: 2008-01-23 18:15    [W:0.220 / U:0.584 seconds]
©2003-2014 Jasper Spaans. Advertise on this site