lkml.org 
[lkml]   [2008]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 01/20 -v5] printk - dont wakeup klogd with interrupts disabled
From
Date

On Wed, 2008-01-23 at 11:02 -0500, Steven Rostedt wrote:

> + if (!irqs_disabled() && wake_klogd)
> wake_up_klogd();

This causes a regression .. When printk is called during an OOPS in
kernels without this change then the OOPS will get logged, since the
logging process (klogd) is woken to handle the messages.. If you apply
this change klogd doesn't wakeup, and hence doesn't log the oops.. So if
you remove the wakeup here you have to add it someplace else to maintain
the logging ..

(I'm not theorizing here, I have defects logged against this specific
piece of code..)

Daniel



\
 
 \ /
  Last update: 2008-01-23 18:09    [W:0.125 / U:0.592 seconds]
©2003-2014 Jasper Spaans. Advertise on this site