lkml.org 
[lkml]   [2008]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] kernel/params.c: fix the module name length in param_sysfs_builtin
    On Jan 23, 2008 7:13 AM, Jan Engelhardt <jengelh@computergmbh.de> wrote:
    > But nf..dada_compat.c gets linked into nf_conntrack_ipv4.ko,
    > and that is what is used in /sys/module - and it fits the 20.
    > Any place where nf_conntrack_l3proto_ipv4_compat would still be used?
    there is a module named nf_conntrack_proto_icmp.ko, length 23. and you
    can find all them by:

    $ make allmodconfig && make modules

    $ find -name '*.ko' -printf '%f\n' |gawk '{print length($0), $0}' |sort -n
    ...
    24 dvb-usb-af9005-remote.ko
    24 dvb-usb-dibusb-common.ko
    25 nf_conntrack_proto_gre.ko
    26 nf_conntrack_netbios_ns.ko
    26 nf_conntrack_proto_sctp.ko
    29 nf_conntrack_proto_udplite.ko

    so currently tha max length of module name is 26 (in
    nf_conntrack_proto_udplite), but still no any length limit to module
    names in Documentation/, so we have to prepare reserved space for
    modules later, or mark MODULE_NAME_LEN as the modules' name length
    limit in Documentation/?

    Simply speaking, MODULE_NAME_LEN does the better job.
    >

    --
    Denis Cheng


    \
     
     \ /
      Last update: 2008-01-23 02:55    [W:0.020 / U:3.600 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site