lkml.org 
[lkml]   [2008]   [Jan]   [22]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
SubjectRE: [PATCH v2] Add DMA engine driver for Freescale MPC85xx processors.
DateTue, 22 Jan 2008 16:25:00 +0800
From"Zhang Wei" <>
Hi, Dan, 

> -----Original Message-----
> From: dan.j.williams@gmail.com 
>
> I do not think all the review comments have been addressed, for
> example my earlier comments about GFP_ATOMIC and spin_lock_irqsave
> [1].  We have two options to take this forward:
> 

Thanks! Some comments need more study, I'll discuss them with you later.

> 1/ Continue to carry this in the async-tx tree and get an
> Acked-by/Reviewed-by tag from Kumar.
> 2/ Move this to Kumar's tree, and coordinate our pull requests to have
> the async-tx updates hit first.
> 
> I prefer option 1, but I will defer to Kumar.
> 

I also prefer option 1. How about now?

Cheers!
Wei.


\
 
 \ /
  Last update: 2008-01-22 08:29    [from the cache]
©2003-2008