lkml.org 
[lkml]   [2008]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Use separate sections for __dev/__cpu/__mem code/data
    On Sun, Jan 20, 2008 at 09:09:03PM +0100, Sam Ravnborg wrote:
    > Introducing separate sections for __dev* (HOTPLUG),
    > __cpu* (HOTPLUG_CPU) and __mem* (MEMORY_HOTPLUG)
    > allows us to do a much more reliable Section mismatch
    > check in modpost. We are no longer dependent on the actual
    > configuration of for example HOTPLUG.
    >
    > This has the effect that all users see much more
    > Section mismatch warnings than before because they
    > were almost all hidden when HOTPLUG was enabled.
    > The advantage of this is that when building a piece
    > of code then it is much more likely that the Section
    > mismatch errors are spotted and the warnings will be
    > felt less random of nature.
    >
    > Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
    > Cc: Greg KH <greg@kroah.com>
    > Cc: Randy Dunlap <randy.dunlap@oracle.com>
    > Cc: Adrian Bunk <bunk@kernel.org>

    I like this a lot. It makes things much more understandable from a
    driver developer's point of view, and would allow us to mark some things
    as freeable when we do not run with a CPU hotplug system :)

    Feel free to add a:
    Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
    to the patch, if you want to take it in your tree.

    thanks,

    greg k-h


    \
     
     \ /
      Last update: 2008-01-22 22:19    [W:0.023 / U:0.152 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site