lkml.org 
[lkml]   [2008]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 10/16] ide: use __ide_set_handler() in ide_execute_command()

    * Use __ide_set_handler() in ide_execute_command().

    While at it:

    * Fix whitespace damage in ide_execute_command().

    Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
    ---
    drivers/ide/ide-iops.c | 21 ++++++++-------------
    1 file changed, 8 insertions(+), 13 deletions(-)

    Index: b/drivers/ide/ide-iops.c
    ===================================================================
    --- a/drivers/ide/ide-iops.c
    +++ b/drivers/ide/ide-iops.c
    @@ -882,22 +882,17 @@ void ide_execute_command(ide_drive_t *dr
    unsigned long flags;
    ide_hwgroup_t *hwgroup = HWGROUP(drive);
    ide_hwif_t *hwif = HWIF(drive);
    -
    +
    spin_lock_irqsave(&ide_lock, flags);
    -
    BUG_ON(hwgroup->handler);
    - hwgroup->handler = handler;
    - hwgroup->expiry = expiry;
    - hwgroup->timer.expires = jiffies + timeout;
    - hwgroup->req_gen_timer = hwgroup->req_gen;
    - add_timer(&hwgroup->timer);
    + __ide_set_handler(drive, handler, timeout, expiry);
    hwif->OUTBSYNC(drive, cmd, IDE_COMMAND_REG);
    - /* Drive takes 400nS to respond, we must avoid the IRQ being
    - serviced before that.
    -
    - FIXME: we could skip this delay with care on non shared
    - devices
    - */
    + /*
    + * Drive takes 400nS to respond, we must avoid the IRQ being
    + * serviced before that.
    + *
    + * FIXME: we could skip this delay with care on non shared devices
    + */
    ndelay(400);
    spin_unlock_irqrestore(&ide_lock, flags);
    }

    \
     
     \ /
      Last update: 2008-01-22 00:25    [W:0.022 / U:0.800 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site