Messages in this thread | | | Date | Mon, 21 Jan 2008 07:41:03 -0800 | From | Mike Travis <> | Subject | Re: [PATCH 1/7] Modules: Fold percpu_modcopy into module.c |
| |
David Miller wrote: > From: travis@sgi.com > Date: Fri, 18 Jan 2008 10:29:54 -0800 > >> percpu_modcopy() is defined multiple times in arch files. However, the only >> user is module.c. Put a static definition into module.c and remove >> the definitions from the arch files. >> >> Cc: Rusty Russell <rusty@rustcorp.com.au> >> Cc: Andi Kleen <ak@suse.de> >> Signed-off-by: Christoph Lameter <clameter@sgi.com> >> Signed-off-by: Mike Travis <travis@sgi.com> > > This doesn't build on sparc64. > > The percpu_modcopy() removal from include/asm-sparc64/percpu.h > leaked into patch #3 instead of being done here in patch #1 > where it belongs (so that this series is properly bisectable). > > It also seems that the include/asm-x86/percpu_{32,64}.h defines > aren't removed in this patch either.
Hi,
I think I have this fixed in the newest version. Yes, it's been a hat dance with some changes coming through the git-x86 patch and others not. I'll submit the new one shortly.
Thanks, Mike
| |