lkml.org 
[lkml]   [2008]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] x86_64: update e820 instead of updating end_pfn v2
From
Date
On Mon, 2008-01-21 at 06:58 +0100, Andi Kleen wrote:
> > {
> > u32 l, h;
> >
> > @@ -661,8 +661,9 @@ static __init int amd_special_default_mt
> > * Memory between 4GB and top of mem is forced WB by this magic bit.
> > * Reserved before K8RevF, but should be zero there.
> > */
> > - if (l & Tom2ForceMemTypeWB)
> > - return 1;
> > + if (l & Tom2Enabled)
> > + if (l & Tom2ForceMemTypeWB)
> > + return 1;
>
> That change is good agreed, but I would suggest to put it into a separate
> patch with a description
>

Perhaps like this:

if (l & (Tom2Enabled|Tom2ForceMemTypeWB))
return 1;
Harvey



\
 
 \ /
  Last update: 2008-01-21 07:09    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site