Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH] rcu: fix section mismatch | Date | Mon, 21 Jan 2008 11:38:38 +1100 |
| |
On Sunday 20 January 2008 08:25:49 Sam Ravnborg wrote: > On Sat, Jan 19, 2008 at 11:56:43AM -0800, Randy Dunlap wrote: > > rcu_online_cpu() should be __cpuinit instead of __devinit. > > So if we have: > CONFIG_HOTPLUG=n > CONFIG_HOTPLUG_CPU=y > > then this is a oops candidate.
At first glance, this can't happen because all CONFIG_HOTPLUG_CPU depends on CONFIG_HOTPLUG or selects it, for all archs.
But CONFIG_PM_SLEEP_SMP selects CONFIG_HOTPLUG_CPU, without requiring CONFIG_HOTPLUG: turning on SUSPEND or HIBERNATION does this.
Perhaps it's time to revisit reverse-depends for select?
Cheers, Rusty.
| |