lkml.org 
[lkml]   [2008]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] rcu: fix section mismatch
Date
On Sunday 20 January 2008 08:25:49 Sam Ravnborg wrote:
> On Sat, Jan 19, 2008 at 11:56:43AM -0800, Randy Dunlap wrote:
> > rcu_online_cpu() should be __cpuinit instead of __devinit.
>
> So if we have:
> CONFIG_HOTPLUG=n
> CONFIG_HOTPLUG_CPU=y
>
> then this is a oops candidate.

At first glance, this can't happen because all CONFIG_HOTPLUG_CPU depends on
CONFIG_HOTPLUG or selects it, for all archs.

But CONFIG_PM_SLEEP_SMP selects CONFIG_HOTPLUG_CPU, without requiring
CONFIG_HOTPLUG: turning on SUSPEND or HIBERNATION does this.

Perhaps it's time to revisit reverse-depends for select?

Cheers,
Rusty.


\
 
 \ /
  Last update: 2008-01-21 04:05    [W:0.071 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site