Messages in this thread | | | Date | Wed, 02 Jan 2008 19:51:21 -0800 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH] x86: fault_{32|64}.c unify do_page_fault |
| |
Harvey Harrison wrote: > > My apologies, testing/compiling on X86_32 here. > >> Do you seriously think code is getting better and more readable because >> of this liberal #ifdef sprinkling in every possible direction? >> > > Well, this of course is not the end of the road, but it makes it > obvious where the differences between 32/64 bit lie and allows > further cleanups to unify these areas over time. This is meant as > a no functionality change path at first.....and it does point out that > for the most part the files are _very_ similar to each other. > > So my plan for now was to move forward with no functional changes and > esentially ifdef or reorder code until we get to identical fault_32/64.c > which then gets moved to a single fault.c > > Then the cleanups happen in one place in one file and it should be easy > to audit the series at the end. But for further patches I'll wait until > the series is further along and tested before submitting. This was how > the kprobes unification went and I think it works fairly well this way. >
One more thing... for code motion/unification patches it's a good thing to verify that the i386 and x86-64 binaries are both unchanged.
-hpa
| |