lkml.org 
[lkml]   [2008]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] procfs: provide slub's /proc/slabinfo


On Wed, 2 Jan 2008, Linus Torvalds wrote:
>
> Actually, I'd much rather just do this instead (on top of your patch)

Side note - and I didn't do this - this also allows you to disable
slabinfo for those people who think it is pointless.

In particular, you could just make that

> +config SLABINFO
> + bool
> + depends on PROC_FS
> + depends on SLAB || SLUB
> + default y

Kconfig entry use something like

bool "Enable /proc/slabinfo support"

(perhaps adding an "if EMBEDDED" at the end), and now people can decide
whether they actually want it or not (independently of whether they use
SLUB or SLAB or whatever). But I left it hardcoded to on, just because I'm
not sure it's worth it.

Linus


\
 
 \ /
  Last update: 2008-01-02 20:49    [W:0.520 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site