Messages in this thread Patch in this message |  | | | Date | Wed, 2 Jan 2008 14:42:19 +0800 | | From | WANG Cong <> | | Subject | (Try #3) [Patch 3/8] S390: Remove 'TOPDIR' from Makefile |
| |
>If the output file does not exist then kbuild does not care about the >dependencies and will just build the target. >On the second invocation when the target exists then kbuild has >created a file named .<target>.cmd that list the dependencies >and this includes any included .c file. >So there is just no pint in defining this dependency explicit >in the MAkefile - kbuild will figure it out automatically. > >The right fix is just to kill the explicit listed dependency.
If I understand you correctly, then the fix should be the below one.
--------> This patch removes TOPDIR from arch/s390/kernel/Makefile.
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> Cc: Sam Ravnborg <sam@ravnborg.org> Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
--- diff --git a/arch/s390/kernel/Makefile b/arch/s390/kernel/Makefile index 56cb710..b3b650a 100644 --- a/arch/s390/kernel/Makefile +++ b/arch/s390/kernel/Makefile @@ -31,7 +31,3 @@ S390_KEXEC_OBJS := machine_kexec.o crash.o S390_KEXEC_OBJS += $(if $(CONFIG_64BIT),relocate_kernel64.o,relocate_kernel.o) obj-$(CONFIG_KEXEC) += $(S390_KEXEC_OBJS) -# -# This is just to get the dependencies... -# -binfmt_elf32.o: $(TOPDIR)/fs/binfmt_elf.c
|  |