lkml.org 
[lkml]   [2008]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: list corruption on ib_srp load in v2.6.24-rc5
From
Date
 > > Can you try this?
>
> That patched oopsed in scsi_remove_host(), but reversing the order has
> survived over 500 insert/probe/remove cycles.
>
> Tested-by: David Dillow <dillowda@ornl.gov>
> ---
> diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c
> index 950228f..77e8b90 100644
> --- a/drivers/infiniband/ulp/srp/ib_srp.c
> +++ b/drivers/infiniband/ulp/srp/ib_srp.c
> @@ -2054,6 +2054,7 @@ static void srp_remove_one(struct ib_device *device)
> list_for_each_entry_safe(target, tmp_target,
> &host->target_list, list) {
> scsi_remove_host(target->scsi_host);
> + srp_remove_host(target->scsi_host);
> srp_disconnect_target(target);

Where do we stand on this? What is the right place to put the
srp_remove_host? Is there a bug somewhere else?

I'd like to get this fixed before 2.6.24 final comes out...

- R.


\
 
 \ /
  Last update: 2008-01-02 18:55    [W:0.334 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site