lkml.org 
[lkml]   [2008]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: x86: remove casts

* Jan Engelhardt <jengelh@computergmbh.de> wrote:

> On Jan 18 2008 11:45, Ingo Molnar wrote:
> >* Jan Engelhardt <jengelh@computergmbh.de> wrote:
> >
> >> This is against x86/mm.
> >
> >hm, it has checkpatch failures -
>
> All false positives.

no, not "All false positives", the first checkpatch failure is a blatant
ugliness that you introduced:

ERROR: use tabs not spaces
#137: FILE: arch/x86/kernel/microcode.c:248:
+^I^I EXT_SIGNATURE_SIZE * i;$

because you converted a tab to a sequence of 10 spaces:

- ext_sig = (struct extended_signature *)((void *)ext_header
- + EXT_HEADER_SIZE + EXT_SIGNATURE_SIZE * i);
+ ext_sig = (void *)ext_header + EXT_HEADER_SIZE +
+ EXT_SIGNATURE_SIZE * i;
<........>

(the second checkpatch warning is a false positive.)

and i applied your patch before i notified you, but apparently you
couldnt be bothered to check. Please do not bother to send patches with
such an attitude, it's just a waste of people's time.

Ingo


\
 
 \ /
  Last update: 2008-01-19 15:11    [W:2.654 / U:0.588 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site