lkml.org 
[lkml]   [2008]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [updated PATCH] xen: fix section usage in xen-head.S and setup.c
Sam Ravnborg wrote:
> Failing to specify "ax" in the pushsection caused ld to generate
> an additional section for .init.text appending a number.
>

Thanks for tracking this down. I think the "ax" appeared and
disappeared over time, but this looks like the proper solution.

Are you going to submit this, or do you want me to pick it up?

> A side effect of this was a section mismatch warning because modpost
> did not recognize a .init.text section named .init.text.1:
> WARNING: vmlinux.o(.text.head+0x247): Section mismatch: reference to .init.text.1:start_kernel (between 'is386' and 'check_x87')
>
> Fix this by hardcoding the "ax" in the pushsection.
> Thanks to Torlaf for reporting this.
>
> Alan Modra provided the hint that made me able to
> locate the root cause of this warning.
> And Mike Frysinger told me how to properly fix it
> using __INIT/__FINIT.
>
> Fix following Section mismatch warning in addition:
> WARNING: vmlinux.o(.text+0x14c8): Section mismatch: reference to .init.data:vsyscall_int80_start (between 'fiddle_vdso' and 'xen_setup_features')
>
> fiddle_vdso was only used from a __init function - so declare it __init.
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Jeremy Fitzhardinge <jeremy@xensource.com>
>

Acked-by: Jeremy Fitzhardinge <jeremy@xensource.com>

Thanks,
J


\
 
 \ /
  Last update: 2008-01-19 23:27    [W:0.061 / U:0.492 seconds]
©2003-2014 Jasper Spaans. Advertise on this site