lkml.org 
[lkml]   [2008]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/5] x86: Add debug of invalid per_cpu map accesses
Andi Kleen wrote:
> On Friday 18 January 2008 19:30:16 travis@sgi.com wrote:
>> Provide a means to trap usages of per_cpu map variables before
>> they are setup. Define CONFIG_DEBUG_PER_CPU_MAPS to activate.
>
> Are you sure that debug option is generally useful enough
> to merge? It seems very specific to your patchkit, but I'm not
> sure it would be worth carrying forever in the kernel.
>
> Better would be probably to just unmap those areas anyways.
>
> -Andi

I thought for a round of testing it'd be worthwhile, particularly
testing randconfig. The next version of percpu changes are coming
soon and I can remove them then. Ideally, you are right, it'd
be nice to not have the percpu memory mapped for processors that are
not present.

One thing that comes into play is that (soon) the boot_pda will be
in the per_cpu area and it's maintained for all "possible" cpus as
it keeps track of some info on "off-lined" cpus. What I was thinking
is that perhaps no memory is allocated (and mapped) until a cpu
becomes not only possible, but probable. This means that until a
cpu is brought online, or discovered via ACPI, then there is no percpu
area and access to an invalid percpu area causes a kernel fault.

Thanks,
Mike


\
 
 \ /
  Last update: 2008-01-18 19:51    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site