Messages in this thread | | | Date | Fri, 18 Jan 2008 13:28:50 -0500 | From | Rik van Riel <> | Subject | Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapped files |
| |
On Fri, 18 Jan 2008 19:11:47 +0100 Miklos Szeredi <miklos@szeredi.hu> wrote:
> > And even in that four-liner, I suspect that the *last* two lines are > > actually incorrect: there's no point in updating the file time when the > > page *becomes* dirty, > > Actually all four lines do that. The first two for a write access on > a present, read-only pte, the other two for a write on a non-present > pte. > > > we should update the file time when it is marked > > clean, and "msync(MS_SYNC)" should update it as part of *that*. > > That would need a new page flag (PG_mmap_dirty?). Do we have one > available?
I thought the page writing stuff looked at (and cleared) the pte dirty bit, too?
-- All rights reversed.
| |