Messages in this thread | | | Date | Fri, 18 Jan 2008 13:14:25 +0100 | From | Michael Opdenacker <> | Subject | Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker.c?compiling |
| |
On 01/18/2008 12:02 PM, Ingo Molnar wrote: > > why didnt you make this: > > obj-$(CONFIG_INPUT_PCSPKR) += pcspeaker.o > > ? > Many thanks for your feedback.
That's what I did first, but if CONFIG_INPUT_PCSPKR=m, arch/x86/kernel/pcspeaker.c gets compiled as a module. While compiling doesn't fail, is this still a valid module? It defines no init and exit functions, and it defines an initcall, which only makes sense at boot time.
We could make pcspeaker.c depend on another switch, like CONFIG_PCSPEAKER on mips. We could offer the possibility to disable it when CONFIG_EMBEDDED is set.
What do you think?
Michael.
-- Michael Opdenacker, Free Electrons Free Embedded Linux Training Materials on http://free-electrons.com/training (More than 1500 pages!)
| |