Messages in this thread | | | Subject | Re: [PATCH] x86: Use v8086_mode helper, trivial unification | From | Harvey Harrison <> | Date | Thu, 17 Jan 2008 18:02:07 -0800 |
| |
On Thu, 2008-01-17 at 20:36 -0500, H. Peter Anvin wrote: > Roland McGrath wrote: > > It's indeed true that &pt_regs is truly the esp value for x86-32 > > kernel-mode trap frames. Because this nonobvious calculation is > > only right for a kernel mode pt_regs and not for a user-mode one, > > I think it would be better to use a name for the inline/macro that > > makes this quite clear, rather than one so generic as "stack_addr". > > Indeed. This was certainly highly nonobvious in the current code. >
What do you think of kernel_sp()
Harvey
| |