lkml.org 
[lkml]   [2008]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: copy srat table and unmap in acpi_parse_table
On Thursday 17 January 2008 12:43:43 pm Ingo Molnar wrote:
>
> * Yinghai Lu <Yinghai.Lu@Sun.COM> wrote:
>
> > [PATCH] x86: copy srat table and unmap in acpi_parse_table
> >
> >
> > the old acpi_numa_slit_init was saving old address in early stage
> > acpi_slit and acpi_parse_table can not unmap address that. the patch
> > copy the slit in the callback, so we could unmap table in
> > acpi_parse_table instead of outside track it.
> >
> > need to revert
> > "
> > commit d8d28f25f33c6a035cdfb1d421c79293d16e5c58
> > Author: Ingo Molnar <mingo@elte.hu>
> > Date: Thu Jan 17 15:26:42 2008 +0100
> >
> > x86: ACPI: fix mapping leaks
> >
> > ioremap_early() is stateful, hence we cannot tolerate mapping leaks.
> > "
> >
> > before appling this patch
>
> do you mean your patch should be applied first, then the
> d8d28f25f33c6a03 patch should applied as second?

d8d28f25f33c6a03 is not needed

>
> Or if d8d28f25f33c6a03 really needs to be reverted to get your system to
> boot properly, which particular bit of it was causing trouble for you?
> (or the whole thing?)

we need to call acpi_os_unmap_memory in acpi_table_parse or just after it.

call it in acpi_table_parse is much cleaner

the problem is that acpi_numa_slit_init do bad assumaption that it still can use address after it's callback function.
so we need to copy the slit.

YH


\
 
 \ /
  Last update: 2008-01-17 23:07    [W:1.542 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site