Messages in this thread |  | | | Subject | RE: [-mm Patch] uml: fix a building error | | Date | Thu, 17 Jan 2008 11:38:53 -0800 | | From | "Pallipadi, Venkatesh" <> | |
>-----Original Message-----
>From: Andrew Morton [mailto:akpm@linux-foundation.org]
>Sent: Thursday, January 17, 2008 10:56 AM
>To: Mariusz Kozlowski
>Cc: WANG Cong; linux-kernel@vger.kernel.org; Jeff Dike;
>user-mode-linux-devel@lists.sourceforge.net; David Miller;
>sparclinux@vger.kernel.org; Ingo Molnar; Thomas Gleixner;
>Pallipadi, Venkatesh
>Subject: Re: [-mm Patch] uml: fix a building error
>
>On Thu, 17 Jan 2008 19:11:13 +0100 Mariusz Kozlowski
><m.kozlowski@tuxland.pl> wrote:
>
>> Hello,
>>
>> > This patch fixes this building error:
>> > ...
>> > drivers/char/mem.c: In function 'read_mem':
>> > drivers/char/mem.c:136: error: implicit declaration of
>function 'unxlate_dev_mem_ptr'
>> > ...
>>
>> I see this on sparc64 as well:
>>
>> CC drivers/char/mem.o
>> drivers/char/mem.c: In function 'read_mem':
>> drivers/char/mem.c:136: error: implicit declaration of
>function 'unxlate_dev_mem_ptr'
>> make[2]: *** [drivers/char/mem.o] Error 1
>> make[1]: *** [drivers/char] Error 2
>> make: *** [drivers] Error 2
>>
>> Does sparc64 need similar fix?
>>
>
>The PAT patches strike again.
>
>Ingo, I think you might need to toss some cross-compilers into
>that build
>test setup of yours.
>
These functions were defined for other archs in asm-generic/iomap.h.
We need all archs including it in io.h. I now see only few archs are
including it..
Apart from unxlate, there is also ioremap_wc which is defined in the
same way.
I can send a patch for this. But, I don't have cross compiler setup for
all archs to test. Andrew, I will need your help.
Thanks,
Venki
|  |