Messages in this thread | | | Subject | RE: [REGRESSION] 2.6.24-rc7: e1000: Detected Tx Unit Hang | Date | Wed, 16 Jan 2008 23:09:47 -0800 | From | "Brandeburg, Jesse" <> |
| |
David Miller wrote: > From: "Brandeburg, Jesse" <jesse.brandeburg@intel.com> > Date: Tue, 15 Jan 2008 13:53:43 -0800 > >> The tx code has an "early exit" that tries to limit the amount of tx >> packets handled in a single poll loop and requires napi or interrupt >> rescheduling based on the return value from e1000_clean_tx_irq. > > That explains everything, thanks Jesse. > > Ok, here is the patch I'll propose to fix this. The goal is to make > it as simple as possible without regressing the thing we were trying > to fix.
We spent Wednesday trying to reproduce (without the patch) these issues without much luck, and have applied the patch cleanly and will continue testing it. Given the simplicity of the changes, and the community testing, I'll give my ack and we will continue testing.
I think we should fix Robert's (unrelated, but in this thread) reported issue before 2.6.24 final if we can, and I'll look at that tonight and tomorrow.
Thanks for your work on this Dave, Jesse
Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
| |