lkml.org 
[lkml]   [2008]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] [3/7] Use shorter addresses in i386 segfault printks
Harvey Harrison wrote:
> On Wed, 2008-01-16 at 23:27 +0100, Andi Kleen wrote:
>> Signed-off-by: Andi Kleen <ak@suse.de>
>>
>> ---
>> arch/x86/mm/fault_32.c | 2 +-
>
> Could use exactly the same in fault_64.c
>
>> #ifdef CONFIG_X86_32
>> - "%s%s[%d]: segfault at %08lx ip %08lx sp %08lx error %lx\n",
>> + "%s%s[%d]: segfault at %lx ip %08lx sp %08lx error %lx\n",
>> #else
>> "%s%s[%d]: segfault at %lx ip %lx sp %lx error %lx\n",
>> #endif
>
> With the ongoing unification work, it would be nice if we could come
> up with a way to unify printks like this. Anyone have any bright ideas
> on a format that will keep the current alignment on 32 and 64 bit with
> the same syntax, or will these tiny ifdefs keep sprouting?
>

Casting to (void *) and using %p is probably your best bet. That's what
it really is anyway.

Note: in the kernel right now, %p doesn't have the leading 0x prefix,
which it probably should...

-hpa


\
 
 \ /
  Last update: 2008-01-17 04:19    [W:0.086 / U:0.168 seconds]
©2003-2011 Jasper Spaans. Advertise on this site