Messages in this thread | | | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: (was: Re:...) [PATCH 12/12] ide-floppy: fix most of the remaining checkpatch.pl issues-v2 | Date | Wed, 16 Jan 2008 23:51:29 +0100 |
| |
On Tuesday 15 January 2008, Borislav Petkov wrote: > ... and finally the last one. Whew! I think we're done here for now. :) > > -- > From: Borislav Petkov <bbpetkov@yahoo.de> > Date: Tue, 15 Jan 2008 21:01:04 +0100 > Subject: ide-floppy: fix most of the remaining checkpatch.pl issues-v2 > > such as > ERROR: switch and case should be at the same indent > ERROR: need spaces around that '=' (ctx:VxV) > ERROR: trailing statements should be on next line > WARNING: no space between function name and open parenthesis '(' > WARNING: printk() should include KERN_ facility level > ERROR: That open brace { should be on the previous line > ERROR: use tabs not spaces > ERROR: do not use assignment in if condition > WARNING: braces {} are not necessary for single statement blocks > ERROR: need space after that ',' (ctx:VxV) > WARNING: line over 80 characters > ERROR: do not use assignment in if condition > ... > and so on. > > Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de>
applied
| |