Messages in this thread |  | | | Date | Wed, 16 Jan 2008 09:11:56 +0100 | | From | Ingo Molnar <> | | Subject | Re: 2.6.24-rc7 lockdep warning when poweroff | |
* Peter Zijlstra <peterz@infradead.org> wrote:
> > > The patch looks ok, one important thing to note is that it means
> > > that all workqueues instantiated by the same __create_workqueue()
> > > call-site share lock dependency chains - I'm unsure if that might
> > > get us into trouble or not.
> >
> > It doesn't seem to have so far ;) I don't think it should. If some
> > code allocates a per-instance workqueue that's much like having an
> > inode lock or so.
>
> We had to split up the inode lock to per filesystem classes, just
> because the lock chains were conflicting between them...
i.e. filesystems can legally have different locking rules wrt. i_lock. I
dont really like it (we should have as simple locking rules as possible)
but it is the VFS status quo :)
Ingo
|  |