lkml.org 
[lkml]   [2008]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 2/2] 8250_pnp: register x86 COM ports at the conventional ttyS names
    On Wed, Jan 16, 2008 at 10:05:43AM -0700, Bjorn Helgaas wrote:
    > static int __devinit
    > +serial_pnp_line(struct uart_port *port)
    > +{
    > +#ifdef CONFIG_X86
    > + switch (port->iobase) {
    > + case 0x3f8: return 0; /* COM1 -> ttyS0 */
    > + case 0x2f8: return 1; /* COM2 -> ttyS1 */
    > + case 0x3e8: return 2; /* COM3 -> ttyS2 */
    > + case 0x2e8: return 3; /* COM4 -> ttyS3 */
    > + }
    > +#endif

    So what if someone intentionally modifies SERIAL_DEFN_PORTS to point
    ttyS[0-3] somewhere else? They also have to modify this code as well.

    --
    Russell King
    Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
    maintainer of:


    \
     
     \ /
      Last update: 2008-01-16 19:45    [W:3.253 / U:0.452 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site