lkml.org 
[lkml]   [2008]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] input: psmouse: fix input_dev leak in lifebook driver
On Tue, 15 Jan 2008 17:04:01 -0500
Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:

> On Sat, Jan 12, 2008 at 03:12:52PM -0500, Andres Salomon wrote:
> >
> > The lifebook driver may register a second input device, but it never
> > unregisters it. This fixes that.
> >
> > Signed-off-by: Andres Salomon <dilinger@debian.org>
>
> Applied, thank you Andres.
>

Hi Dmitry,

There's one additional patch, I don't know if you saw it; the subject
was "check return value of input_register_device() in hil_ptr.c's init".


Also, I've found myself needing to provide my own device_attribute for
the OLPC psmouse driver; I couldn't use PSMOUSE_DEFINE_ATTR(), as its
set_helper callback calls psmouse_disable.

static DEVICE_ATTR(powered, S_IWUSR | S_IRUGO, hgpk_show_powered,
hgpk_set_powered);

Unfortunately, in order to not be racy, hgpk_set_powered needs to
deal with psmouse_mutex. Which method of dealing with this would
you prefer? I could either make psmouse_mutex no longer static,
provide psmouse_mutex locking functions (declared in psmouse.h), or
put psmouse_mutex into 'struct psmouse'. Or, if you have any other
ideas..



\
 
 \ /
  Last update: 2008-01-16 19:01    [W:0.216 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site