lkml.org 
[lkml]   [2008]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] libata: make libata use printk_header() and mprintk
Randy Dunlap wrote:
>> - ata_dev_printk(dev, KERN_WARNING,
>> -"Drive reports diagnostics failure. This may indicate a drive\n");
>> - ata_dev_printk(dev, KERN_WARNING,
>> -"fault or invalid emulation. Contact drive vendor for information.\n");
>> - }
>
> Looks to me like several of these + lines have indent problems:
> following lines (i.e., not first line) of function call should be
> indented more than the first line:

Putting one more tab would put good part of those lines off the 80col
limit. Hmmm... but I agree it looks ugly. I'll add one or two spaces
there.

>> + ata_dev_printk(dev, KERN_WARNING,
>> + "Drive reports diagnostics failure. This may indicate a drive\n"
>> + "fault or invalid emulation. Contact drive vendor for information.\n");

Thanks.

--
tejun


\
 
 \ /
  Last update: 2008-01-16 03:57    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site