lkml.org 
[lkml]   [2008]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC/PATCH 4/8] revoke: core code V7
On Tue, Jan 15, 2008 at 04:14:54PM +0100, Peter Zijlstra wrote:
> Humm, we were trying to get rid of file_list_lock(), this puts up
> another user of the sb file list.
>
> Also, that loop looks horribly expensive: n*(1+m); where n is the list
> size, and m the number of matching fds.
>
> Granted, I see no other options either.

Something like the loop above is not going to go in for sure. Once we
get rid of the sb->s_files we can put the list_head in struct file to
new use eventually if we don't want to get rid of it. E.g. and
per-inode list would be much better than the per-superblock one and
would regularize what the tty driver is doing.

But I'm not too interesting in hashing out these details currently,
my primary concern is to get the per-mount r/o plus fallout like the
correct remount r/o and file_list_lock removal in and stable first.



\
 
 \ /
  Last update: 2008-01-15 18:31    [W:0.095 / U:0.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site