Messages in this thread |  | | | Date | Tue, 15 Jan 2008 12:08:52 +0900 | | From | KOSAKI Motohiro <> | | Subject | Re: [RFC][PATCH 4/5] memory_pressure_notify() caller | |
Hi Kame,
> > > > + notify_threshold = (zone->pages_high +
> > > > + zone->lowmem_reserve[MAX_NR_ZONES-1]) * 2;
> > > > +
> > > Why MAX_NR_ZONES-1 ?
> >
> > this is intent to max lowmem_reserve.
> >
> Ah, my point is.. how about this ?
> ==
> if (page_zoneid(page) != ZONE_DMA)
> notify_threshold = zone->pages_high +
> zone->lowmem_reserve[page_zoneid(page) - 1] * 2;
your point out is very good point.
but judged by zone size is more better, may be.
on some 64bit system, ZONE_DMA is 4GB.
small memory system can't ignore it.
fortunately, zone size check can at free_area_init_core().
- kosaki
|  |