lkml.org 
[lkml]   [2008]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: kconfig: support option env="" [Was: kconfig: use $K64BIT to set 64BIT with all*config targets]
    On Mon, Jan 14, 2008 at 04:49:48AM +0100, Roman Zippel wrote:
    > Hi,
    >
    > On Sun, 6 Jan 2008, Sam Ravnborg wrote:
    >
    > > Please get back to me so we can finsih this patch and have it applied.
    > > I will split the patch in two btw.
    >
    > I reworked the patch a little and split it into three.

    Thanks Roman.
    I will test and apply tonight.

    Removal of KERNELVERSION in patch #3 is wrong as the frontend
    uses KERNELVERSION to display the kernel version in their title.
    I will drop the deletion before I apply the patch.


    >
    > > > + if (sym->flags & SYMBOL_AUTO)
    > > > + sym->flags &= ~SYMBOL_WRITE;
    > > > +
    > >
    > > Why is this change needed?
    > > It is non-obvious to me so please explain and I will add a comment.
    >
    > Automatically generated symbols are not saved, this was previously not
    > needed as they weren't in the menu structure.
    OK

    >
    > > I did it like this:
    > > menu_warn(current_entry,
    > > "config %s: redefining environment symbol from '%s' to '%s'",
    > > sym->name, env, sym2->name);
    >
    > I omitted the prefix, it's inconsistent with other warnings.
    OK

    Thanks,
    Sam


    \
     
     \ /
      Last update: 2008-01-14 07:01    [W:0.021 / U:30.452 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site