lkml.org 
[lkml]   [2008]   [Jan]   [14]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateMon, 14 Jan 2008 09:27:25 +0100
FromIngo Molnar <>
SubjectRe: [PATCH] x86: fix ioport unification on 32-bit [was: Re: hwclock failure in x86.git]
* Chris Wright <chrisw@sous-sol.org> wrote:

> * Ingo Molnar (mingo@elte.hu) wrote:
> > thanks for tracking it down. I pulled that commit for now. But it would 
> > be nice to figure out what's going on there.
> 
> Zach was right. The unification was broken for 32-bit; it was missing 
> the actual pushf/popf EFLAGS manipluation (set_iopl_mask()) and 
> would've broken task switching between processes w/ different iopl in 
> paravirt guests too.  64-bit sys_iopl just does pt_regs->flags 
> modification and lets syscall/sysret plus ptregscall sync and do 
> EFLAGS update.
> 
> Also, use of volatile looks like leftover cruft.
> 
> This patch in on top of Miguel's (can respin to standalone if that's 
> better). [...]

thanks, applied.

	Ingo


\
 
 \ /
  Last update: 2008-01-14 08:31    [from the cache]
©2003-2008