Messages in this thread | | | Date | Mon, 14 Jan 2008 17:47:36 +0100 | From | Ingo Molnar <> | Subject | Re: [patch 06/11] PAT x86: Refactoring i386 cpa |
| |
* Andi Kleen <andi@firstfloor.org> wrote:
> venkatesh.pallipadi@intel.com writes: > > > This makes 32 bit cpa similar to x86_64 and makes it easier for > > following PAT patches. > > Please don't do this -- that would be a nightmare merging with my CPA > series. > > This means adding the _addr() entry point is ok (although it should > not be needed on i386 because it doesn't do the end_pfn_mapped trick), > but not a wide scale refactoring.
yeah, i think we can unify after your cpa fixes and enhancements just fine - as you did the changes symmetrically for 32-bit and 64-bit. Hopefully i'll be able to upload the current PAT stuff in x86.git later today so that you can merge the cpa items ontop of it.
Ingo
| |